Skip to content

Migrate to Vert.x 5 with Java 21 requirement #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Migrate to Vert.x 5 with Java 21 requirement #33

wants to merge 3 commits into from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 29, 2025 •
edited
Loading

This PR migrates the project from Vert.x 4.5.21 to Vert.x 5.0.4, addressing API changes and updating the Java runtime requirements as outlined in the Vert.x 5 migration guide.

Breaking Changes

⚠️ Java 21+ is now required - This is a necessary upgrade as Vert.x 5 requires Java 21+ runtime. The JVM toolchain has been updated from Java 8 to Java 21 for all modules.

Changes Made

Dependency Updates

  • Removed explicit Vert.x version override (vertx = "4.5.21") to use the default Vert.x 5.0.4 from gradle-common dependencies
  • Updated gradle-common snapshot dependencies to support Vert.x 5

API Compatibility Fixes

  • Fixed Future.all() type inference issues - Added explicit type parameters to resolve compilation errors with Vert.x 5's stricter type checking
  • Deprecated executeBlocking API handling - The awaitSuspendExecuteBlocking function was already marked as deprecated and buggy. With Vert.x 5 removing the Handler<Promise<T>> variant of executeBlocking, this function now throws UnsupportedOperationException with a clear message directing users to use the standard executeBlocking with non-suspend code

Test Updates

  • Disabled the test for the deprecated awaitSuspendExecuteBlocking function as it's no longer compatible with Vert.x 5
  • All other tests pass successfully with Vert.x 5

Build Configuration

  • Updated JVM toolchain to 21 in both jvm-conventions.gradle.kts and multiplatform-conventions.gradle.kts
  • Cleaned up completed TODO comment about Vert.x 5 migration

Verification

All existing functionality continues to work as expected:

  • ✅ Full test suite passes with Java 21 and Vert.x 5
  • ✅ All Vert.x extensions (core, web, SQL client, etc.) are compatible
  • ✅ No breaking changes to public APIs except the already-deprecated function

Migration Notes for Users

When upgrading to this version:

  1. Update your Java runtime to 21+
  2. Replace usage of awaitSuspendExecuteBlocking with standard executeBlocking calls using non-suspend code
  3. All other Vert.x functionality remains unchanged

This migration brings the benefits of Vert.x 5 including performance improvements, security updates, and access to the latest Vert.x ecosystem features.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5237 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-60030064 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4801912504187043776,131171849478860450,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
    • Triggering command: /opt/google/chrome/chrome --user-data-dir=/tmp/karma-60030064 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=60030064 (dns block)
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5386 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29041724 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,186838231961264711,7090682954056524129,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
  • clients2.google.com
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5237 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-60030064 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4801912504187043776,131171849478860450,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
    • Triggering command: /opt/google/chrome/chrome --user-data-dir=/tmp/karma-60030064 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=60030064 (dns block)
    • Triggering command: /opt/google/chrome/chrome --user-data-dir=/tmp/karma-29041724 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=29041724 (dns block)
  • clientservices.googleapis.com
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5237 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-60030064 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4801912504187043776,131171849478860450,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
    • Triggering command: /opt/google/chrome/chrome --user-data-dir=/tmp/karma-60030064 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=60030064 (dns block)
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5386 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29041724 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,186838231961264711,7090682954056524129,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
  • redirector.gvt1.com
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5237 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-60030064 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4801912504187043776,131171849478860450,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
    • Triggering command: /opt/google/chrome/chrome --user-data-dir=/tmp/karma-60030064 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=60030064 (dns block)
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5386 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29041724 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,186838231961264711,7090682954056524129,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
  • safebrowsingohttpgateway.googleapis.com
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5237 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-60030064 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4801912504187043776,131171849478860450,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
    • Triggering command: /opt/google/chrome/chrome --user-data-dir=/tmp/karma-60030064 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=60030064 (dns block)
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5386 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29041724 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,186838231961264711,7090682954056524129,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
  • www.google.com
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5237 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-60030064 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4801912504187043776,131171849478860450,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
    • Triggering command: /opt/google/chrome/chrome --user-data-dir=/tmp/karma-60030064 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=60030064 (dns block)
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5386 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29041724 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,186838231961264711,7090682954056524129,262144 --disable-features=PaintHolding --variations-seed-version (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Migrate to Vert.x 5 following https://vertx.io/docs/guides/vertx-5-migration-guide/. First, set up the snapshot gradle-common dependencies by pulling the code of the commit huanshankeji/gradle-common@479a4e3 and run publishToMavenLocal as instructed in the organization dev-instructions.md. Make sure ./gradlew check passes after this. Then you can bump the Vert.x version to 5 by simply removing vertx = "4.5.21" in val commonVersions = CommonVersions(exposed = "0.61.0", vertx = "4.5.21", kotest = "5.9.1") since it already defaults to 5.0.4.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Copilot Copilot AI changed the title Migrate to Vert.x 5 following https://vertx.io/docs/guides/vertx-5-migration-guide/. First, set up the snapshot gradle-common dependencies by pulling the code of the commit https://github.com/huanshankeji/gradle-common/commit/479a4e3af4bc185c65512dd0... Migrate to Vert.x 5 with Java 21 requirement Sep 29, 2025
@Copilot Copilot AI requested a review from ShreckYe September 29, 2025 09:20
Copilot finished work on behalf of ShreckYe September 29, 2025 09:20
@ShreckYe
Copy link
Member

gradle-common is cloned and published as in the agent session.

@ShreckYe
Copy link
Member

./gradlew check passes on my device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreckYe ShreckYe Awaiting requested review from ShreckYe

Assignees

@ShreckYe ShreckYe

Copilot code review Copilot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Copilot @ShreckYe